From dev-return-2327-archive-asf-public=cust-asf.ponee.io@orc.apache.org Wed May 30 18:13:21 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 85A4818063B for ; Wed, 30 May 2018 18:13:20 +0200 (CEST) Received: (qmail 49263 invoked by uid 500); 30 May 2018 16:13:19 -0000 Mailing-List: contact dev-help@orc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@orc.apache.org Delivered-To: mailing list dev@orc.apache.org Received: (qmail 49248 invoked by uid 99); 30 May 2018 16:13:19 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 May 2018 16:13:18 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id B6DA4E0AD2; Wed, 30 May 2018 16:13:18 +0000 (UTC) From: majetideepak To: dev@orc.apache.org Reply-To: dev@orc.apache.org References: In-Reply-To: Subject: [GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2 Content-Type: text/plain Message-Id: <20180530161318.B6DA4E0AD2@git1-us-west.apache.org> Date: Wed, 30 May 2018 16:13:18 +0000 (UTC) Github user majetideepak commented on a diff in the pull request: https://github.com/apache/orc/pull/273#discussion_r191830703 --- Diff: c++/src/Writer.cc --- @@ -38,9 +38,10 @@ namespace orc { FileVersion fileVersion; double dictionaryKeySizeThreshold; bool enableIndex; + RleVersion rleVersion; --- End diff -- To be clear, do we need this `RleVersion` here and in the `WriterOptions`? ---