From dev-return-2209-archive-asf-public=cust-asf.ponee.io@orc.apache.org Fri May 4 17:13:23 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 6DAB6180634 for ; Fri, 4 May 2018 17:13:22 +0200 (CEST) Received: (qmail 64775 invoked by uid 500); 4 May 2018 15:13:21 -0000 Mailing-List: contact dev-help@orc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@orc.apache.org Delivered-To: mailing list dev@orc.apache.org Received: (qmail 64755 invoked by uid 99); 4 May 2018 15:13:20 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 May 2018 15:13:20 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C4CA2F402F; Fri, 4 May 2018 15:13:20 +0000 (UTC) From: omalley To: dev@orc.apache.org Reply-To: dev@orc.apache.org References: In-Reply-To: Subject: [GitHub] orc pull request #265: ORC-334: [C++] Add AppVeyor support for integration o... Content-Type: text/plain Message-Id: <20180504151320.C4CA2F402F@git1-us-west.apache.org> Date: Fri, 4 May 2018 15:13:20 +0000 (UTC) Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/265#discussion_r186114158 --- Diff: c++/test/CreateTestFiles.cc --- @@ -31,8 +31,8 @@ void writeCustomOrcFile(const std::string& filename, const orc::proto::Metadata& metadata, const orc::proto::Footer& footer, - const std::vector& version, - uint writerVersion) { + const std::vector& version, --- End diff -- We generally prefer to use explicitly sized types, so uint64_t or uint32_t would be better. ---