orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jamesclampffer <...@git.apache.org>
Subject [GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2
Date Wed, 30 May 2018 22:04:33 GMT
Github user jamesclampffer commented on a diff in the pull request:

    https://github.com/apache/orc/pull/273#discussion_r191932328
  
    --- Diff: c++/include/orc/Writer.hh ---
    @@ -38,6 +38,11 @@ namespace orc {
         CompressionStrategy_COMPRESSION
       };
     
    +  enum RleVersion {
    +    RleVersion_1,
    --- End diff --
    
    You may want to explicitly assign values here to ensure the addition of new encodings
or refactoring work can't unintentionally change the underlying integer values.


---

Mime
View raw message