orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2
Date Wed, 30 May 2018 16:13:18 GMT
Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/273#discussion_r191830703
  
    --- Diff: c++/src/Writer.cc ---
    @@ -38,9 +38,10 @@ namespace orc {
         FileVersion fileVersion;
         double dictionaryKeySizeThreshold;
         bool enableIndex;
    +    RleVersion rleVersion;
    --- End diff --
    
    To be clear, do we need this `RleVersion` here and in the `WriterOptions`?


---

Mime
View raw message