orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2
Date Wed, 30 May 2018 15:33:38 GMT
Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/273#discussion_r191815756
  
    --- Diff: c++/test/TestWriter.cc ---
    @@ -1174,5 +1170,5 @@ namespace orc {
         }
       }
     
    -  INSTANTIATE_TEST_CASE_P(OrcTest, WriterTest, Values(RleVersion_1, RleVersion_2));
    +  INSTANTIATE_TEST_CASE_P(OrcTest, WriterTest, Values(FileVersion::v_0_11(), FileVersion::v_0_11()));
    --- End diff --
    
    Should be `Values(FileVersion::v_0_11(), FileVersion::v_0_12()))`


---

Mime
View raw message