orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From yuruiz <...@git.apache.org>
Subject [GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2
Date Tue, 29 May 2018 08:18:35 GMT
Github user yuruiz commented on a diff in the pull request:

    https://github.com/apache/orc/pull/273#discussion_r191337994
  
    --- Diff: c++/src/CMakeLists.txt ---
    @@ -179,15 +179,15 @@ set(SOURCE_FILES
       OrcFile.cc
       Reader.cc
       RLEv1.cc
    -  RLEv2.cc
    +  RleDecoderV2.cc
    +  RleEncoderV2.cc
    --- End diff --
    
    The reason I prefer to Split Encoder and Decoder into two files for V2 simply because
the code has grow too big that it would be very difficult to navigate if combine them into
a single file.


---

Mime
View raw message