orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc pull request #273: ORC-343 Enable C++ writer to support RleV2
Date Mon, 28 May 2018 22:02:58 GMT
Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/273#discussion_r191269083
  
    --- Diff: c++/src/CMakeLists.txt ---
    @@ -179,15 +179,15 @@ set(SOURCE_FILES
       OrcFile.cc
       Reader.cc
       RLEv1.cc
    -  RLEv2.cc
    +  RleDecoderV2.cc
    +  RleEncoderV2.cc
    --- End diff --
    
    We split the Encoder and Decoder into two files for V2 and not for V1. Can we combine
them into a single file for V2 as well?


---

Mime
View raw message