orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc pull request #265: ORC-334: [C++] Add AppVeyor support for integration o...
Date Mon, 14 May 2018 11:44:42 GMT
Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/265#discussion_r187922554
  
    --- Diff: c++/src/Timezone.cc ---
    @@ -710,7 +710,11 @@ namespace orc {
        * Get the local timezone.
        */
       const Timezone& getLocalTimezone() {
    +#ifdef _MSC_VER
    +    return getTimezoneByName("UTC");
    --- End diff --
    
    I also think that it is better to leave the conversion to the client/customer. We should
ideally change the conversion for Nix* systems but cannot due to backward compatibility. We
should be able to converge both Java and C++ timestamps in ORC 2.0.
    For Windows, since this is the first official build support, we should be okay to use
"UTC" and document this behavior.
    I will merge this PR end of today if there are no objections.


---

Mime
View raw message