orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wgtmac <...@git.apache.org>
Subject [GitHub] orc pull request #265: ORC-334: [C++] Add AppVeyor support for integration o...
Date Tue, 08 May 2018 19:27:21 GMT
Github user wgtmac commented on a diff in the pull request:

    --- Diff: c++/src/Timezone.cc ---
    @@ -710,7 +710,11 @@ namespace orc {
        * Get the local timezone.
       const Timezone& getLocalTimezone() {
    +#ifdef _MSC_VER
    +    return getTimezoneByName("UTC");
    --- End diff --
    If we cannot find writer timezone from the stripe footer, we assume the writer and reader
are in the same timezone. TimestampColumnReader tries to convert the timestamp to UTC to get
the same wall clock time as the writer. Unless the files are written under UTC, otherwise
we may get wrong timestamps if we set local timezone to UTC by default.


View raw message