orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wgtmac <...@git.apache.org>
Subject [GitHub] orc pull request #265: ORC-334: [C++] Add AppVeyor support for integration o...
Date Mon, 07 May 2018 17:35:33 GMT
Github user wgtmac commented on a diff in the pull request:

    https://github.com/apache/orc/pull/265#discussion_r186492444
  
    --- Diff: c++/src/Timezone.cc ---
    @@ -710,7 +710,11 @@ namespace orc {
        * Get the local timezone.
        */
       const Timezone& getLocalTimezone() {
    +#ifdef _MSC_VER
    +    return getTimezoneByName("UTC");
    --- End diff --
    
    Recently we have change to UTC everywhere in C++ code. Is it better to delete getLocalTimezone
function to avoid confusion?


---

Mime
View raw message