orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request #265: ORC-334: [C++] Add AppVeyor support for integration o...
Date Mon, 07 May 2018 16:27:22 GMT
Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/265#discussion_r186474701
  
    --- Diff: c++/src/Timezone.cc ---
    @@ -710,7 +710,11 @@ namespace orc {
        * Get the local timezone.
        */
       const Timezone& getLocalTimezone() {
    +#ifdef _MSC_VER
    +    return getTimezoneByName("UTC");
    --- End diff --
    
    Because there isn't a direct windows equivalent.
    
    Here is what Java writes about it-
    https://docs.oracle.com/javase/8/docs/technotes/guides/troubleshoot/time-zone002.html
    
    There is a registry setting, but it uses a non-standard set of names *doh*. The easiest
way would be to create a Java jar and run that to determine the local timezone.


---

Mime
View raw message