orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request #249: [ORC-341] Support time zone as a parameter for Java r...
Date Fri, 04 May 2018 16:44:39 GMT
Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/249#discussion_r186137062
  
    --- Diff: java/core/src/java/org/apache/orc/impl/writer/WriterImplV2.java ---
    @@ -373,7 +379,11 @@ private void flushStripe() throws IOException {
           OrcProto.StripeFooter.Builder builder =
               OrcProto.StripeFooter.newBuilder();
           if (writeTimeZone) {
    -        builder.setWriterTimezone(TimeZone.getDefault().getID());
    +        if (useUTCTimeZone) {
    +          builder.setWriterTimezone(TimeZone.getTimeZone("UTC").getID());
    --- End diff --
    
    I'd be tempted to just use setWriterTimezone("UTC"), because we'll already fail if UTC
is called something else.


---

Mime
View raw message