orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wgtmac <...@git.apache.org>
Subject [GitHub] orc pull request #249: [ORC-341] Support time zone as a parameter for Java r...
Date Thu, 03 May 2018 03:39:14 GMT
Github user wgtmac commented on a diff in the pull request:

    https://github.com/apache/orc/pull/249#discussion_r185691649
  
    --- Diff: java/core/src/java/org/apache/orc/impl/writer/TimestampTreeWriter.java ---
    @@ -28,7 +28,9 @@
     import org.apache.orc.impl.SerializationUtils;
     
     import java.io.IOException;
    -import java.sql.Timestamp;
    +import java.text.DateFormat;
    +import java.text.ParseException;
    +import java.text.SimpleDateFormat;
     import java.util.TimeZone;
     
     public class TimestampTreeWriter extends TreeWriterBase {
    --- End diff --
    
    We should also change writeBatch function below.
    
    The input vector.isUTC may be true while writer.isUseUTCTimestamp() is false; vice versa.
In this case, we need to convert them to correct writer timezone.


---

Mime
View raw message