orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t3rmin4t0r <...@git.apache.org>
Subject [GitHub] orc pull request #259: ORC-248. PhysicalFsWriter sometimes passes negative p...
Date Tue, 01 May 2018 17:13:02 GMT
Github user t3rmin4t0r commented on a diff in the pull request:

    https://github.com/apache/orc/pull/259#discussion_r185275471
  
    --- Diff: java/core/src/java/org/apache/orc/OrcConf.java ---
    @@ -152,7 +152,9 @@
       OVERWRITE_OUTPUT_FILE("orc.overwrite.output.file", "orc.overwrite.output.file", false,
         "A boolean flag to enable overwriting of the output file if it already exists.\n"),
       IS_SCHEMA_EVOLUTION_CASE_SENSITIVE("orc.schema.evolution.case.sensitive", "orc.schema.evolution.case.sensitive",
true,
    -          "A boolean flag to determine if the comparision of field names in schema evolution
is case sensitive .\n")
    +          "A boolean flag to determine if the comparision of field names in schema evolution
is case sensitive .\n"),
    +  WRITE_SHORTENED_BLOCKS("orc.write.shortened.blocks", null, false,
    --- End diff --
    
    Might as well call it what it is "orc.write.variable.length.blocks"


---

Mime
View raw message