orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wgtmac <...@git.apache.org>
Subject [GitHub] orc pull request #249: [ORC-341] Support time zone as a parameter for Java r...
Date Fri, 27 Apr 2018 21:11:25 GMT
Github user wgtmac commented on a diff in the pull request:

    https://github.com/apache/orc/pull/249#discussion_r184807989
  
    --- Diff: java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java ---
    @@ -975,6 +992,8 @@ public void nextVector(ColumnVector previousVector,
           TimestampColumnVector result = (TimestampColumnVector) previousVector;
           super.nextVector(previousVector, isNull, batchSize);
     
    +      // TODO: If context.isUseUTCTimestamp(), set TimestampColumnVector.useUTC to true
    --- End diff --
    
    I think it is better to set storage-api to 3.0.0 and fix this TODO in this patch as well.


---

Mime
View raw message