orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From t3rmin4t0r <...@git.apache.org>
Subject [GitHub] orc pull request #245: ORC-161: Proposal for new decimal encodings and stati...
Date Thu, 12 Apr 2018 03:44:50 GMT
Github user t3rmin4t0r commented on a diff in the pull request:

    https://github.com/apache/orc/pull/245#discussion_r180957943
  
    --- Diff: site/_docs/file-tail.md ---
    @@ -249,12 +249,26 @@ For booleans, the statistics include the count of false and true
values.
     }
     ```
     
    -For decimals, the minimum, maximum, and sum are stored.
    +For decimals, the minimum, maximum, and sum are stored. In ORC 2.0,
    +string represetion is deprecated and DecimalStatistics uses integers
    +which have better performance.
     
     ```message DecimalStatistics {
      optional string minimum = 1;
      optional string maximum = 2;
      optional string sum = 3;
    + // for precision <= 18 
    + optional sint64 minimum64 = 4;
    + optional sint64 maximum64 = 5;
    + optional sint64 sum64 = 6;
    --- End diff --
    
    sum64 needs to be Int128 


---

Mime
View raw message