From dev-return-1871-archive-asf-public=cust-asf.ponee.io@orc.apache.org Thu Mar 1 23:59:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id ED258180671 for ; Thu, 1 Mar 2018 23:59:06 +0100 (CET) Received: (qmail 1550 invoked by uid 500); 1 Mar 2018 22:59:06 -0000 Mailing-List: contact dev-help@orc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@orc.apache.org Delivered-To: mailing list dev@orc.apache.org Received: (qmail 1437 invoked by uid 99); 1 Mar 2018 22:59:05 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Mar 2018 22:59:05 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id DB3C3DFA0E; Thu, 1 Mar 2018 22:59:04 +0000 (UTC) From: omalley To: dev@orc.apache.org Reply-To: dev@orc.apache.org References: In-Reply-To: Subject: [GitHub] orc pull request #222: ORC-310 better error handling for codec Content-Type: text/plain Message-Id: <20180301225904.DB3C3DFA0E@git1-us-west.apache.org> Date: Thu, 1 Mar 2018 22:59:04 +0000 (UTC) Github user omalley commented on a diff in the pull request: https://github.com/apache/orc/pull/222#discussion_r171719585 --- Diff: java/core/src/java/org/apache/orc/impl/WriterImpl.java --- @@ -645,6 +645,8 @@ public void appendUserMetadata(List userMetadata) { return ReaderImpl.deserializeStats(builder.getStatisticsList()); } + // TODO: remove this --- End diff -- Remove the changes in this file. We do not want a guice dependency. ---