orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xndai <...@git.apache.org>
Subject [GitHub] orc pull request #233: ORC-322: [C++] Fix writing & reading timestamp
Date Sat, 24 Mar 2018 14:07:13 GMT
Github user xndai commented on a diff in the pull request:

    https://github.com/apache/orc/pull/233#discussion_r176910052
  
    --- Diff: c++/src/ColumnReader.cc ---
    @@ -336,8 +336,7 @@ namespace orc {
               }
             }
             int64_t writerTime = secsBuffer[i] + epochOffset;
    -        secsBuffer[i] = writerTime +
    -          writerTimezone.getVariant(writerTime).gmtOffset;
    +        secsBuffer[i] = writerTimezone.convertToUTC(writerTime);
    --- End diff --
    
    If it reads a file created by Java writer with writer timezone other than GMT, you are
not going to get the same clock reading from ColumnPrinter, are you?


---

Mime
View raw message