orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request #231: ORC-317: [C++] check that indices in the protobuf typ...
Date Tue, 20 Mar 2018 23:13:27 GMT
Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/231#discussion_r175949471
  
    --- Diff: c++/src/Reader.cc ---
    @@ -897,6 +897,27 @@ namespace orc {
         return REDUNDANT_MOVE(postscript);
       }
     
    +  // ORC-317: check that indices in the type tree are valid, so we won't crash
    +  // when we convert the proto::Types to TypeImpls.
    +  void checkProtoTypeIds(int &index, const proto::Footer &footer) {
    --- End diff --
    
    I'd suggest only passing in the footer here and check all of the types in a loop.


---

Mime
View raw message