orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stiga-huang <...@git.apache.org>
Subject [GitHub] orc pull request #233: ORC-322: [C++] Fix writing & reading timestamp
Date Sat, 17 Mar 2018 12:35:26 GMT
Github user stiga-huang commented on a diff in the pull request:

    https://github.com/apache/orc/pull/233#discussion_r175256695
  
    --- Diff: c++/src/Vector.cc ---
    @@ -436,4 +438,8 @@ namespace orc {
               + static_cast<uint64_t>(
                   (data.capacity() + nanoseconds.capacity()) * sizeof(int64_t));
       }
    +
    +  int64_t TimestampVectorBatch::getSecondInWriterTZ(uint64_t rowId) {
    +    return data[rowId] + writerTimezone->getVariant(data[rowId]).gmtOffset;
    --- End diff --
    
    Can we wrap the logic `ts + timezone->getVariant(ts).gmtOffset` as a function (e.g.
`Timezone::getLocalSecs(long utcSecs)`) in Timezone? Looks like we frequently use it.


---

Mime
View raw message