orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request #222: ORC-310 better error handling for codec
Date Thu, 01 Mar 2018 22:59:04 GMT
Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/222#discussion_r171720713
  
    --- Diff: java/core/src/java/org/apache/orc/impl/ReaderImpl.java ---
    @@ -472,8 +473,9 @@ public static OrcTail extractFileTail(ByteBuffer buffer, long fileLength,
long m
             .setPostscript(ps)
             .setFooter(footer)
             .setFileLength(fileLength);
    +      isCodecError = false;
         } finally {
    --- End diff --
    
    try {} finally is pretty broken. You are better off using the try-with-resources statement.


---

Mime
View raw message