orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request #222: ORC-310 better error handling for codec
Date Thu, 01 Mar 2018 22:59:04 GMT
Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/222#discussion_r171719585
  
    --- Diff: java/core/src/java/org/apache/orc/impl/WriterImpl.java ---
    @@ -645,6 +645,8 @@ public void appendUserMetadata(List<OrcProto.UserMetadataItem>
userMetadata) {
         return ReaderImpl.deserializeStats(builder.getStatisticsList());
       }
     
    +  // TODO: remove this
    --- End diff --
    
    Remove the changes in this file. We do not want a guice dependency.


---

Mime
View raw message