orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc issue #220: ORC-306 Correct pre-1970 timestamps that were off by one sec...
Date Tue, 27 Feb 2018 16:40:34 GMT
Github user omalley commented on the issue:

    https://github.com/apache/orc/pull/220
  
    So the fix detects whether the Timestamp class has the bug or not and then either compensates
or doesn't. It also ensures that the TimestampColumnVector.time values are set correctly with
the milliseconds on the bottom.
    
    The test does more now. First of all, instead of going from 56.1000 to 56.1999 seconds
incrementing by 0.0001, which doesn't reveal the bug, it goes from 56.0000 to 56.1999 seconds
incrementing by 0.0002. It also checks the values from the TimestampColumnVector rather than
comparing using Timestamp.


---

Mime
View raw message