orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prasanthj <...@git.apache.org>
Subject [GitHub] orc pull request #218: ORC-301. `extractFileTail` should open a file in `try...
Date Thu, 15 Feb 2018 18:52:25 GMT
Github user prasanthj commented on a diff in the pull request:

    https://github.com/apache/orc/pull/218#discussion_r168572505
  
    --- Diff: java/core/src/java/org/apache/orc/impl/ReaderImpl.java ---
    @@ -516,12 +516,13 @@ OrcTail buildEmptyTail() {
     
       protected OrcTail extractFileTail(FileSystem fs, Path path,
           long maxFileLength) throws IOException {
    -    FSDataInputStream file = fs.open(path);
    +    FSDataInputStream file = null;
         ByteBuffer buffer;
         OrcProto.PostScript ps;
         OrcProto.FileTail.Builder fileTailBuilder = OrcProto.FileTail.newBuilder();
         long modificationTime;
         try {
    --- End diff --
    
    Line 610 doesn't add much value as close() will throw IOException anyway which should
be sufficient to know the reason.


---

Mime
View raw message