orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request #213: ORC-278 - Create in memory KeyProvider class
Date Wed, 07 Feb 2018 17:31:26 GMT
Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/213#discussion_r166694083
  
    --- Diff: java/core/src/test/org/apache/orc/TestInMemoryKeystore.java ---
    @@ -0,0 +1,111 @@
    +package org.apache.orc;
    +
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + * <p>
    + * http://www.apache.org/licenses/LICENSE-2.0
    + * <p>
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +import org.apache.commons.lang.StringUtils;
    +import org.apache.orc.impl.HadoopShims;
    +import org.junit.Assert;
    +import org.junit.Test;
    +
    +import java.io.IOException;
    +import java.security.Key;
    +import java.util.Arrays;
    +import java.util.List;
    +
    +/**
    + * Test {@link InMemoryKeystore} class
    + */
    +public class TestInMemoryKeystore {
    +
    +  private static final InMemoryKeystore memoryKeystore = new InMemoryKeystore();
    +
    +  /* populate the keystore */
    +  static {
    +    try {
    +      memoryKeystore.addKey("key128", EncryptionAlgorithm.AES_128, "123".getBytes());
    +      memoryKeystore.addKey("key256", EncryptionAlgorithm.AES_256, "secret123".getBytes());
    +      memoryKeystore.addKey("key256short", EncryptionAlgorithm.AES_256, "5".getBytes());
    +    } catch (IOException e) {
    +      Assert.fail("Failed to add keys, cause: "+e.toString());
    +    }
    +
    +  }
    +
    +  public TestInMemoryKeystore() {
    +    super();
    +  }
    +
    +  @Test
    +  public void testgetKeyNames() throws IOException {
    +
    +    Assert.assertTrue(memoryKeystore.getKeyNames().contains("key128"));
    +    Assert.assertTrue(memoryKeystore.getKeyNames().contains("key256"));
    +    Assert.assertTrue(memoryKeystore.getKeyNames().contains("key256short"));
    +
    +  }
    +
    +  @Test
    +  public void testGetCurrentKeyVersion() {
    +
    +    final HadoopShims.KeyMetadata metadata = memoryKeystore
    +        .getCurrentKeyVersion("key256");
    +    Assert.assertEquals("key256", metadata.getKeyName());
    +    if(InMemoryKeystore.SUPPORTS_AES_256) {
    +      Assert.assertEquals(EncryptionAlgorithm.AES_256, metadata.getAlgorithm());
    +    } else {
    +      Assert.assertEquals(EncryptionAlgorithm.AES_128, metadata.getAlgorithm());
    +    }
    +
    +    Assert.assertEquals(0, metadata.getVersion());
    +
    +  }
    +
    +  @Test
    +  public void testGetLocalKey() {
    +
    +    HadoopShims.KeyMetadata metadata = memoryKeystore
    +        .getCurrentKeyVersion("key128");
    +    byte[] iv = new byte[EncryptionAlgorithm.AES_128.getIvLength()];
    +
    +    final Key key128 = memoryKeystore.getLocalKey(metadata, iv);
    +    Assert.assertEquals("AES", key128.getAlgorithm());
    +
    +  }
    +
    +  @Test
    +  public void testRollNewVersion() throws IOException {
    +
    +    Assert.assertEquals(0, memoryKeystore.getCurrentKeyVersion("key128").getVersion());
    +    memoryKeystore.rollNewVersion("key128", "NewSecret".getBytes());
    +    Assert.assertEquals(1, memoryKeystore.getCurrentKeyVersion("key128").getVersion());
    +
    +  }
    +
    +  @Test
    +  public void testDuplicateKeyNames() {
    +    try {
    +      memoryKeystore.addKey("key128", EncryptionAlgorithm.AES_128, "exception".getBytes());
    +      Assert.fail("Keys with same name cannot be added.");
    +    } catch (IOException e) {
    +      Assert.assertTrue(StringUtils.contains(e.toString(), "Key key128 already exists."));
    +    }
    +
    --- End diff --
    
    You should add a test case with multiple versions of a key.


---

Mime
View raw message