From dev-return-1779-archive-asf-public=cust-asf.ponee.io@orc.apache.org Sat Jan 20 19:43:49 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 462AD18066D for ; Sat, 20 Jan 2018 19:43:49 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 35AEA160C38; Sat, 20 Jan 2018 18:43:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 74629160C28 for ; Sat, 20 Jan 2018 19:43:48 +0100 (CET) Received: (qmail 28655 invoked by uid 500); 20 Jan 2018 18:43:47 -0000 Mailing-List: contact dev-help@orc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@orc.apache.org Delivered-To: mailing list dev@orc.apache.org Received: (qmail 28639 invoked by uid 99); 20 Jan 2018 18:43:47 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 20 Jan 2018 18:43:47 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4DF12E2F03; Sat, 20 Jan 2018 18:43:47 +0000 (UTC) From: xndai To: dev@orc.apache.org Reply-To: dev@orc.apache.org References: In-Reply-To: Subject: [GitHub] orc pull request #212: ORC-293: [C++] Fix RleEncoderV1 for case when sizeof(... Content-Type: text/plain Message-Id: <20180120184347.4DF12E2F03@git1-us-west.apache.org> Date: Sat, 20 Jan 2018 18:43:47 +0000 (UTC) Github user xndai commented on a diff in the pull request: https://github.com/apache/orc/pull/212#discussion_r162789950 --- Diff: c++/include/orc/Common.hh --- @@ -69,7 +69,7 @@ namespace orc { UNKNOWN_WRITER = INT32_MAX }; - enum CompressionKind { + enum CompressionKind : std::int64_t { --- End diff -- The definition of CompressionKind_MAX already makes CompressionKind a int64 type. Enum base type is a C++ 11 feature and should at least be configurable through orc-config.hh ---