orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xndai <...@git.apache.org>
Subject [GitHub] orc pull request #212: ORC-293: [C++] Fix RleEncoderV1 for case when sizeof(...
Date Sat, 20 Jan 2018 18:43:47 GMT
Github user xndai commented on a diff in the pull request:

    https://github.com/apache/orc/pull/212#discussion_r162789950
  
    --- Diff: c++/include/orc/Common.hh ---
    @@ -69,7 +69,7 @@ namespace orc {
         UNKNOWN_WRITER = INT32_MAX
       };
     
    -  enum CompressionKind {
    +  enum CompressionKind : std::int64_t {
    --- End diff --
    
    The definition of CompressionKind_MAX already makes CompressionKind a int64 type. Enum
base type is a C++ 11 feature and should at least be configurable through orc-config.hh


---

Mime
View raw message