orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc pull request #204: ORC-283: Enable the cmake build to pick specified pat...
Date Thu, 21 Dec 2017 12:50:10 GMT
Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/204#discussion_r158269151
  
    --- Diff: cmake_modules/FindGTest.cmake ---
    @@ -28,7 +28,7 @@ find_path (GTEST_INCLUDE_DIR gmock/gmock.h HINTS
       NO_DEFAULT_PATH
       PATH_SUFFIXES "include")
     
    -find_library (GTEST_LIBRARIES NAMES gmock PATHS
    +find_library (GTEST_LIBRARIES NAMES gmock HINTS
    --- End diff --
    
    `HINTS` is apt here. `PATHS` must only be used for hardcoded guesses.
    https://cmake.org/cmake/help/v3.0/command/find_library.html


---

Mime
View raw message