orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From moresandeep <...@git.apache.org>
Subject [GitHub] orc pull request #184: Orc 256 unmask range option
Date Thu, 07 Dec 2017 20:14:40 GMT
Github user moresandeep commented on a diff in the pull request:

    https://github.com/apache/orc/pull/184#discussion_r155628665
  
    --- Diff: java/core/src/java/org/apache/orc/impl/mask/RedactMaskFactory.java ---
    @@ -114,6 +120,10 @@
       private final boolean maskDate;
       private final boolean maskTimestamp;
     
    +  // index tuples that are not to be masked
    +  private final SortedMap<Integer,Integer> unmaskIndexRanges = Collections.synchronizedSortedMap(new
TreeMap());
    --- End diff --
    
    Hello @xndai,
    Thanks for the review, I was trying to be cautious, but I can get rid of it.


---

Mime
View raw message