orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wgtmac <...@git.apache.org>
Subject [GitHub] orc pull request #198: Orc-272: Minor porting changes.
Date Thu, 07 Dec 2017 19:37:31 GMT
Github user wgtmac commented on a diff in the pull request:

    https://github.com/apache/orc/pull/198#discussion_r155619755
  
    --- Diff: c++/src/Int128.cc ---
    @@ -22,6 +22,7 @@
     #include <iomanip>
     #include <iostream>
     #include <sstream>
    +#include <algorithm> // std::min
    --- End diff --
    
    nit: you may want to sort them alphabetically.


---

Mime
View raw message