orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jcrist <...@git.apache.org>
Subject [GitHub] orc pull request #193: ORC-267: INSTALL NOTICES and LICENSE to binary tarbal...
Date Mon, 04 Dec 2017 17:28:50 GMT
Github user jcrist commented on a diff in the pull request:

    https://github.com/apache/orc/pull/193#discussion_r154717285
  
    --- Diff: CMakeLists.txt ---
    @@ -105,6 +105,11 @@ INCLUDE(ThirdpartyToolchain)
     set (EXAMPLE_DIRECTORY ${CMAKE_SOURCE_DIR}/examples)
     
     add_subdirectory(c++)
    +
    +install(
    +  FILES LICENSE NOTICE
    +  DESTINATION .)
    --- End diff --
    
    If I do `make install`, these just get placed in my root directory. Other apache projects
(e.g. arrow, parquet-cpp) don't install the `LICENSE` or `NOTICE` (the header files all have
the license information), so why is this needed? This is why I removed these in #192, sorry
if there was a good reason for installing these.


---

Mime
View raw message