Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E0154200D41 for ; Wed, 22 Nov 2017 23:00:20 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id DF1B6160BEC; Wed, 22 Nov 2017 22:00:20 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2732D160BFD for ; Wed, 22 Nov 2017 23:00:20 +0100 (CET) Received: (qmail 98424 invoked by uid 500); 22 Nov 2017 22:00:19 -0000 Mailing-List: contact dev-help@orc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@orc.apache.org Delivered-To: mailing list dev@orc.apache.org Received: (qmail 98413 invoked by uid 99); 22 Nov 2017 22:00:19 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Nov 2017 22:00:19 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 031A0DFC2F; Wed, 22 Nov 2017 22:00:19 +0000 (UTC) From: majetideepak To: dev@orc.apache.org Reply-To: dev@orc.apache.org References: In-Reply-To: Subject: [GitHub] orc issue #192: ORC-266: [C++] Cleanup cmake scripts Content-Type: text/plain Message-Id: <20171122220019.031A0DFC2F@git1-us-west.apache.org> Date: Wed, 22 Nov 2017 22:00:19 +0000 (UTC) archived-at: Wed, 22 Nov 2017 22:00:21 -0000 Github user majetideepak commented on the issue: https://github.com/apache/orc/pull/192 +1 LGTM. Thanks! I will verify if these changes pass on all our supported OSes and merge this. ---