orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jim Crist (JIRA)" <j...@apache.org>
Subject [jira] [Created] (ORC-266) [C++] A few issues with cmake scripts and non-vendored third party libraries
Date Wed, 22 Nov 2017 21:52:00 GMT
Jim Crist created ORC-266:
-----------------------------

             Summary: [C++] A few issues with cmake scripts and non-vendored third party libraries
                 Key: ORC-266
                 URL: https://issues.apache.org/jira/browse/ORC-266
             Project: ORC
          Issue Type: Bug
          Components: C++
            Reporter: Jim Crist


Currently there are a few issues with the cmake build system:

- Running `make install` (or `make package`) when using any non-vendored third party library
results in copying all files not matching `"*.so|*.dylib"` from the `*_HOME/lib` directory
into the `lib/` directory. This is because third party libraries are being installed via a
filter instead of specific file paths. This is definitely a bug.

- There is no easy way to specify third party library locations when using orc as an `ExternalProject`
in another cmake project. This is easily fixed by separating the defining of `*_HOME` variables
from their use, which allows e.g. `-DSNAPPY_HOME=...` to work.

- There is no way to avoid building the tests

- There is no way to avoid building the tools

- The LICENSE and NOTICE get installed into the root directory, which is not where they should
go. Since the header files all contain the license header, and other apache projects don't
install the license, the lines installing these files should be removable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message