orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc pull request #191: ORC-265: [C++] Add documentation for C++ build suppor...
Date Tue, 28 Nov 2017 22:50:47 GMT
Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/191#discussion_r153647593
  
    --- Diff: site/_docs/building.md ---
    @@ -70,3 +70,25 @@ To build:
     % mvn package
     ~~~
     
    +## Building just C++
    +
    +~~~ shell
    +% mkdir build
    +% cd build
    +% cmake .. -DBUILD_JAVA=OFF
    +% make package test-out
    +~~~
    +
    +## Specify third-party libraries for C++ build
    +
    +~~~ shell
    +% mkdir build
    +% cd build
    +% GTEST_HOME=<PATH to Google Test library> \
    +  SNAPPY_HOME=<PATH to Snappy library> \
    +  ZLIB_HOME=<PATH to ZLIB library> \
    +  LZ4_HOME=<PATH to LZ4 library> \
    +  PROTOBUF_HOME=<PATH to Protobuf library> \
    +  cmake  .. -DBUILD_JAVA=OFF
    +% make package test-out
    --- End diff --
    
    That is correct. The recent changes made did put the dependency on CMake variables. Fixed
the comments.


---

Mime
View raw message