orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc issue #170: ORC-207: [C++] Enable users the ability to provide their own...
Date Wed, 27 Sep 2017 02:17:36 GMT
Github user majetideepak commented on the issue:

    In this PR, `FindProtobuf.cmake` checks if the specified path `PROTOBUF_HOME` contains
the required headers and sets `PROTOBUF_INCLUDE_DIRS`, checks for the library and sets `PROTOBUF_LIBRARIES`,
and checks for the executable and sets `PROTOBUF_EXECUTABLE`. Even if one of them is missing
from the user specified location, the protobuf library gets downloaded. In a future patch,
we can extend the `FindX.cmake` to check default system paths (except for protobuf). But by
default, we should only download.


View raw message