orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc issue #151: ORC-226 Support getWriterId in c++ reader interface
Date Tue, 26 Sep 2017 18:33:37 GMT
Github user omalley commented on the issue:

    https://github.com/apache/orc/pull/151
  
    Ok, this is generally good. A couple of points that I'll fix as part of committing:
    
    * the API should use specific types (eg. uint32_t instead of int)
    * since the enums are for serialization, I think it will be clearer if we assign explicit
values for them
    * if the footer doesn't have a writerId, it is ORC_JAVA_WRITER and not an exception



---

Mime
View raw message