orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sundapeng <...@git.apache.org>
Subject [GitHub] orc pull request #161: ORC-210: Add encoding for Double, Float.
Date Wed, 20 Sep 2017 06:58:34 GMT
Github user sundapeng commented on a diff in the pull request:

    https://github.com/apache/orc/pull/161#discussion_r139888584
  
    --- Diff: java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java ---
    @@ -688,17 +700,23 @@ protected void skipRows(long items) throws IOException {
       }
     
       public static class DoubleTreeReader extends TreeReader {
    -    protected InStream stream;
    -    private final SerializationUtils utils;
    +    private DoubleReader reader;
    --- End diff --
    
    Hi @pudidic , thank you for the patch!
    I found `reader` should be `protected` here for Hive integration. [EncodedTreeReaderFactory](https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java#L950)
    And since we would remove a `protected` variable, could we reuse the `stream`?


---

Mime
View raw message