orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sadikovi <...@git.apache.org>
Subject [GitHub] orc pull request #169: ORC-203 Modify the StringStatistics to trim the minim...
Date Mon, 18 Sep 2017 20:53:58 GMT
Github user sadikovi commented on a diff in the pull request:

    https://github.com/apache/orc/pull/169#discussion_r139537518
  
    --- Diff: java/core/src/java/org/apache/orc/impl/ColumnStatisticsImpl.java ---
    @@ -608,8 +609,23 @@ public void merge(ColumnStatisticsImpl other) {
           OrcProto.StringStatistics.Builder str =
             OrcProto.StringStatistics.newBuilder();
           if (getNumberOfValues() != 0) {
    -        str.setMinimum(getMinimum());
    -        str.setMaximum(getMaximum());
    +        String value = getMinimum();
    +        if (value != null && value.length() > 1024) {
    --- End diff --
    
    I suggest you make it a constant somewhere and reference that.
    
    I would also consider making it configurable with default value of `1024`.


---

Mime
View raw message