orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From xndai <...@git.apache.org>
Subject [GitHub] orc pull request #134: Orc 17
Date Mon, 11 Sep 2017 09:22:20 GMT
Github user xndai commented on a diff in the pull request:

    https://github.com/apache/orc/pull/134#discussion_r138019713
  
    --- Diff: c++/include/orc/OrcFile.hh ---
    @@ -103,12 +103,18 @@ namespace orc {
       };
     
       /**
    -   * Create a stream to a local file.
    +   * Create a stream to a local file or HDFS file if path begins with "hdfs://"
    --- End diff --
    
    why do you want readLocalFile() to handle hdfs files? You already have readHdfsFile()
which does exactly that.


---

Mime
View raw message