Mailing-List: contact dev-help@orc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@orc.apache.org
From: xndai <git@git.apache.org>
To: dev@orc.apache.org
Reply-To: dev@orc.apache.org
References: <git-pr-152-orc@git.apache.org>
In-Reply-To: <git-pr-152-orc@git.apache.org>
Subject: [GitHub] orc pull request #152: ORC-227: [C++] Fix docker failure due to ExternalProj...
Content-Type: text/plain
Message-Id: <20170810175035.F0AF0E964E@git1-us-west.apache.org>
Date: Thu, 10 Aug 2017 17:50:35 +0000 (UTC)
archived-at: Thu, 10 Aug 2017 17:50:38 -0000

Github user xndai commented on a diff in the pull request:

    https://github.com/apache/orc/pull/152#discussion_r132522783
  
    --- Diff: c++/src/ByteRLE.cc ---
    @@ -26,9 +26,9 @@
     
     namespace orc {
     
    -  const size_t MINIMUM_REPEAT = 3;
    -  const size_t MAXIMUM_REPEAT = 127 + MINIMUM_REPEAT;
    -  const size_t MAX_LITERAL_SIZE = 128;
    +  const int MINIMUM_REPEAT = 3;
    +  const int MAXIMUM_REPEAT = 127 + MINIMUM_REPEAT;
    +  const int MAX_LITERAL_SIZE = 128;
    --- End diff --
    
    I don't see the mismatch warnings on CentOS7 docker image. Where did you see that? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---