Return-Path: <dev-return-1275-archive-asf-public=cust-asf.ponee.io@orc.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id DE4D4200CDD
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon,  7 Aug 2017 21:25:29 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id DD2CF165E55; Mon,  7 Aug 2017 19:25:29 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 2FC3B165E53
	for <archive-asf-public@cust-asf.ponee.io>; Mon,  7 Aug 2017 21:25:29 +0200 (CEST)
Received: (qmail 18654 invoked by uid 500); 7 Aug 2017 19:25:26 -0000
Mailing-List: contact dev-help@orc.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@orc.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@orc.apache.org>
List-Post: <mailto:dev@orc.apache.org>
List-Id: <dev.orc.apache.org>
Reply-To: dev@orc.apache.org
Delivered-To: mailing list dev@orc.apache.org
Received: (qmail 18460 invoked by uid 99); 7 Aug 2017 19:25:25 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 07 Aug 2017 19:25:25 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id EF886E96F5; Mon,  7 Aug 2017 19:25:24 +0000 (UTC)
From: omalley <git@git.apache.org>
To: dev@orc.apache.org
Reply-To: dev@orc.apache.org
References: <git-pr-128-orc@git.apache.org>
In-Reply-To: <git-pr-128-orc@git.apache.org>
Subject: [GitHub] orc pull request #128: ORC-178 Implement Basic C++ Writer and Writer Option
Content-Type: text/plain
Message-Id: <20170807192524.EF886E96F5@git1-us-west.apache.org>
Date: Mon,  7 Aug 2017 19:25:24 +0000 (UTC)
archived-at: Mon, 07 Aug 2017 19:25:30 -0000

Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/128#discussion_r131717175
  
    --- Diff: c++/include/orc/Writer.hh ---
    @@ -0,0 +1,228 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +#ifndef ORC_WRITER_HH
    +#define ORC_WRITER_HH
    +
    +#include "orc/Common.hh"
    +#include "orc/orc-config.hh"
    +#include "orc/Type.hh"
    +#include "orc/Vector.hh"
    +
    +#include <memory>
    +#include <string>
    +#include <vector>
    +
    +namespace orc {
    +
    +  // classes that hold data members so we can maintain binary compatibility
    +  struct WriterOptionsPrivate;
    +
    +  enum EncodingStrategy {
    --- End diff --
    
    Are you going to use EncodingStrategy soon? Very few users use it on the Java implementation, but we don't want to put in the switch if it doesn't do anything.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---