Mailing-List: contact dev-help@orc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@orc.apache.org
From: omalley <git@git.apache.org>
To: dev@orc.apache.org
Reply-To: dev@orc.apache.org
References: <git-pr-128-orc@git.apache.org>
In-Reply-To: <git-pr-128-orc@git.apache.org>
Subject: [GitHub] orc pull request #128: ORC-178 Implement Basic C++ Writer and Writer Option
Content-Type: text/plain
Message-Id: <20170807192524.D3DB3F32C0@git1-us-west.apache.org>
Date: Mon,  7 Aug 2017 19:25:24 +0000 (UTC)
archived-at: Mon, 07 Aug 2017 19:25:28 -0000

Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/128#discussion_r131718185
  
    --- Diff: c++/include/orc/Writer.hh ---
    @@ -0,0 +1,228 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +#ifndef ORC_WRITER_HH
    +#define ORC_WRITER_HH
    +
    +#include "orc/Common.hh"
    +#include "orc/orc-config.hh"
    +#include "orc/Type.hh"
    +#include "orc/Vector.hh"
    +
    +#include <memory>
    +#include <string>
    +#include <vector>
    +
    +namespace orc {
    +
    +  // classes that hold data members so we can maintain binary compatibility
    +  struct WriterOptionsPrivate;
    +
    +  enum EncodingStrategy {
    +    EncodingStrategy_SPEED = 0,
    +    EncodingStrategy_COMPRESSION
    +  };
    +
    +  enum CompressionStrategy {
    +    CompressionStrategy_SPEED = 0,
    +    CompressionStrategy_COMPRESSION
    +  };
    +
    +  class Timezone;
    +
    +  /**
    +   * Options for creating a Writer.
    +   */
    +  class WriterOptions {
    +  private:
    +    ORC_UNIQUE_PTR<WriterOptionsPrivate> privateBits;
    +
    +  public:
    +    WriterOptions();
    +    WriterOptions(const WriterOptions&);
    +    WriterOptions(WriterOptions&);
    +    WriterOptions& operator=(const WriterOptions&);
    +    virtual ~WriterOptions();
    +
    +    /**
    +     * Set the strip size.
    +     */
    +    WriterOptions& setStripeSize(uint64_t size);
    +
    +    /**
    +     * Get the strip size.
    +     * @return if not set, return default value.
    +     */
    +    uint64_t getStripeSize() const;
    +
    +    /**
    +     * Set the data compression block size.
    +     */
    +    WriterOptions& setCompressionBlockSize(uint64_t size);
    +
    +    /**
    +     * Get the data compression block size.
    +     * @return if not set, return default value.
    +     */
    +    uint64_t getCompressionBlockSize() const;
    +
    +    /**
    +     * Set row index stride.
    +     */
    +    WriterOptions& setRowIndexStride(uint64_t stride);
    --- End diff --
    
    Please add a comment here that setting the stride to 0 disables the index.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---