orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iamhumanbeing <...@git.apache.org>
Subject [GitHub] orc pull request #159: ORC-175: ORC-232: add jmh-generator-annprocess in pom...
Date Wed, 23 Aug 2017 03:27:55 GMT
Github user iamhumanbeing commented on a diff in the pull request:

    https://github.com/apache/orc/pull/159#discussion_r134650087
  
    --- Diff: java/bench/src/java/org/apache/orc/bench/CompressionKind.java ---
    @@ -53,6 +54,8 @@ public OutputStream create(OutputStream out) throws IOException {
             return new GZIPOutputStream(out);
           case SNAPPY:
             return new SnappyCodec().createOutputStream(out);
    +      case ISAL:
    --- End diff --
    
    1. igzip is only part of the ISAL.
    2. igzip only support level 0 - level 1 compression, it can not replace libz totally.
    3. igzip's API can not replace ligz's API directly. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message