orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From wgtmac <...@git.apache.org>
Subject [GitHub] orc pull request #149: ORC-224: Implement column writers of primitive types
Date Wed, 23 Aug 2017 00:09:21 GMT
Github user wgtmac commented on a diff in the pull request:

    https://github.com/apache/orc/pull/149#discussion_r134630866
  
    --- Diff: c++/test/TestWriter.cc ---
    @@ -209,5 +209,612 @@ namespace orc {
         }
         EXPECT_FALSE(rowReader->next(*batch));
       }
    -}
     
    +  TEST(Writer, writeStringAndBinaryColumn) {
    --- End diff --
    
    It is better to keep them in different test cases for following reasons:
    1. It seems that they share the same logic in testing but they differ in the data construction
and verification parts for different types. It has the same rationale with the design of ColumnWriter
classes.
    2. We may have different design/implementations for some types in the future. It is much
easier to test them if we de-couple them into separate tests.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message