orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dongjoon-hyun <...@git.apache.org>
Subject [GitHub] orc pull request #160: ORC-233 Allow `orc.include.columns` to be empty
Date Mon, 21 Aug 2017 17:59:08 GMT
Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/orc/pull/160#discussion_r134293310
  
    --- Diff: java/mapreduce/src/java/org/apache/orc/mapred/OrcInputFormat.java ---
    @@ -58,7 +58,7 @@
        */
       public static boolean[] parseInclude(TypeDescription schema,
                                            String columnsStr) {
    -    if (columnsStr == null ||
    +    if (StringUtils.isBlank(columnsStr) ||
    --- End diff --
    
    BTW, is this enough for ORC column selection to return all null fields?
    It looks to me that it returns all value fields. I mean without column selection.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message