orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc issue #134: Orc 17
Date Fri, 18 Aug 2017 15:06:36 GMT
Github user omalley commented on the issue:

    https://github.com/apache/orc/pull/134
  
    
    
    .. Owen
    
    > On Aug 18, 2017, at 07:14, jamesclampffer <notifications@github.com> wrote:
    > 
    > @majetideepak Is there a way to get the OSX CI to use a generic LLVM/Clang install
rather than the one that gets shipped with OSX?
    > 
    
    Don't do that. If it doesn't compile with the "real" Mac OS compiler, you'll break my
dev platform.
    > Apparently they apply a patch to Clang to break thread_local, my understanding is
they don't want to break the ABI if they ever get around to making builtin thread local specialized
for their OS.
    > 
    >         .Case("cxx_thread_local",
    > -                 LangOpts.CPlusPlus11 && PP.getTargetInfo().isTLSSupported()
&&
    > -                 !PP.getTargetInfo().getTriple().isOSDarwin())
    > +                 LangOpts.CPlusPlus11 && PP.getTargetInfo().isTLSSupported())
    > Otherwise this won't get coverage on OSX CI builds.
    > 
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub, or mute the thread.
    > 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message