orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From prasanthj <...@git.apache.org>
Subject [GitHub] orc pull request #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS co...
Date Sat, 12 Aug 2017 00:53:26 GMT
Github user prasanthj commented on a diff in the pull request:

    https://github.com/apache/orc/pull/154#discussion_r132805602
  
    --- Diff: java/core/src/java/org/apache/orc/impl/MemoryManagerImpl.java ---
    @@ -81,6 +81,7 @@ public Thread getOwner() {
        */
       public MemoryManagerImpl(Configuration conf) {
         double maxLoad = OrcConf.MEMORY_POOL.getDouble(conf);
    +    ROWS_BETWEEN_CHECKS = OrcConf.ROWS_BETWEEN_CHECKS.getLong(conf);
    --- End diff --
    
    I don't think we want to support too larger interval for this. Having very high value
means prolonging the memory check which is bad (flush often as opposed to don't flush and
fail). 
    1 to 10000 may be good range. Also please make a note in the description that keeping
too low value is for testing only and can cause too early flushes in some cases and generate
sub-optimal orc files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message