orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ekoifman <...@git.apache.org>
Subject [GitHub] orc pull request #154: ORC-228 Make MemoryManagerImpl.ROWS_BETWEEN_CHECKS co...
Date Sat, 12 Aug 2017 00:33:14 GMT
Github user ekoifman commented on a diff in the pull request:

    https://github.com/apache/orc/pull/154#discussion_r132804794
  
    --- Diff: java/core/src/java/org/apache/orc/impl/MemoryManagerImpl.java ---
    @@ -81,6 +81,7 @@ public Thread getOwner() {
        */
       public MemoryManagerImpl(Configuration conf) {
         double maxLoad = OrcConf.MEMORY_POOL.getDouble(conf);
    +    ROWS_BETWEEN_CHECKS = OrcConf.ROWS_BETWEEN_CHECKS.getLong(conf);
    --- End diff --
    
    default is set OrcConf - 5000
    what would be reasonable range of valid values?  [1,?]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message