orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From majetideepak <...@git.apache.org>
Subject [GitHub] orc pull request #152: ORC-227: [C++] Fix docker failure due to ExternalProj...
Date Thu, 10 Aug 2017 14:55:44 GMT
Github user majetideepak commented on a diff in the pull request:

    https://github.com/apache/orc/pull/152#discussion_r132477368
  
    --- Diff: c++/src/ByteRLE.cc ---
    @@ -26,9 +26,9 @@
     
     namespace orc {
     
    -  const size_t MINIMUM_REPEAT = 3;
    -  const size_t MAXIMUM_REPEAT = 127 + MINIMUM_REPEAT;
    -  const size_t MAX_LITERAL_SIZE = 128;
    +  const int MINIMUM_REPEAT = 3;
    +  const int MAXIMUM_REPEAT = 127 + MINIMUM_REPEAT;
    +  const int MAX_LITERAL_SIZE = 128;
    --- End diff --
    
    @xndai @wgtmac These changes are required to avoid signed and unsigned mismatch warnings.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message