orc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From omalley <...@git.apache.org>
Subject [GitHub] orc pull request #128: ORC-178 Implement Basic C++ Writer and Writer Option
Date Mon, 07 Aug 2017 19:25:24 GMT
Github user omalley commented on a diff in the pull request:

    https://github.com/apache/orc/pull/128#discussion_r131739382
  
    --- Diff: c++/src/Vector.cc ---
    @@ -35,6 +35,7 @@ namespace orc {
                                               hasNulls(false),
                                               memoryPool(pool) {
         // PASS
    --- End diff --
    
    I was using "// PASS" to mean it was intentionally empty. Since you added a statement,
you should remove the comment also.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message